refactor: replace strings.Replace with strings.ReplaceAll#2075
Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom May 16, 2022
Juneezee:refactor/strings-replaceall
Merged
refactor: replace strings.Replace with strings.ReplaceAll#2075FabianKramm merged 1 commit intodevspace-sh:masterfrom Juneezee:refactor/strings-replaceall
FabianKramm merged 1 commit intodevspace-sh:masterfrom
Juneezee:refactor/strings-replaceall
Conversation
strings.ReplaceAll(s, old, new) is a wrapper function for strings.Replace(s, old, new, -1). But strings.ReplaceAll is more readable and removes the hardcoded -1. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
✅ Deploy Preview for devspace-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FabianKramm
approved these changes
May 16, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@Juneezee thanks a lot for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Replace
strings.Replace(s, old, new, -1)withstrings.ReplaceAll(s, old, new).strings.ReplaceAllis a wrapper function forstrings.Replace, butstrings.ReplaceAllis more readable and removes the hardcoded-1.Please provide a short message that should be published in the DevSpace release notes
N/A, this is a non-user facing change
What else do we need to know?